linux-kernel - Re: [PATCH v11 4/4] usb: host: enable USB offload during system sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOuDEK3b6vM_vyLDHjxYWu1UCaZ53hNse91bjkoB7vPaebEMPg@mail.gmail.com>
Date: Wed, 16 Apr 2025 18:05:00 +0800
From: Guan-Yu Lin <guanyulin@...gle.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: mathias.nyman@...el.com, stern@...land.harvard.edu, gargaditya08@...e.com, 
	kekrby@...il.com, jeff.johnson@....qualcomm.com, elder@...nel.org, 
	quic_zijuhu@...cinc.com, ben@...adent.org.uk, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 4/4] usb: host: enable USB offload during system sleep

On Fri, Apr 11, 2025 at 10:02 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Apr 08, 2025 at 03:57:24AM +0000, Guan-Yu Lin wrote:
> > @@ -736,6 +737,7 @@ struct usb_device {
> >       unsigned use_generic_driver:1;
> >
> >       refcount_t offload_usage;
> > +     unsigned offload_at_suspend:1;
>
> Please take a second and think about how the memory is now layed out
> here with your new addition.  The tool 'pahole' is your friend...
>
> thanks,
>
> greg k-h

Thanks for providing this helpful information. I'll reconstruct the
struct to minimize the effect of new additions.

Regards,
Guan-Yu