linux-kernel - Re: [PATCH] kunit: qemu_configs: Disable faulting tests on 32-bit SPARC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250416120254-182b9ffb-746c-4bd1-854b-8a2d8ca3c5b2@linutronix.de>
Date: Wed, 16 Apr 2025 12:06:41 +0200
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: David Gow <davidgow@...gle.com>
Cc: Rae Moar <rmoar@...gle.com>, Shuah Khan <skhan@...uxfoundation.org>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit: qemu_configs: Disable faulting tests on 32-bit
 SPARC

On Wed, Apr 16, 2025 at 05:38:25PM +0800, David Gow wrote:
> The 32-bit sparc configuration (--arch sparc) crashes on
> the kunit_fault_test. It's known that some architectures don't handle
> deliberate segfaults in kernel mode well, so there's a config switch to
> disable tests which rely upon it by default.
> 
> Use this for the sparc config, making sure the default config for it
> passes.
> 
> Fixes: 87c9c1631788 ("kunit: tool: add support for QEMU")
> Signed-off-by: David Gow <davidgow@...gle.com>

Thanks!

I am wondering if this should instead be done in lib/kunit/Kconfig.
Not all users of kunit are guaranteed to use kunit.py.

In any case:

Reviewed-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Tested-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

FYI the usercopy test is also broken:

[12:05:43]     # usercopy_test_valid: EXPECTATION FAILED at lib/tests/usercopy_kunit.c:209
[12:05:43]     Expected val_u64 == 0x5a5b5c5d6a6b6c6d, but
[12:05:43]         val_u64 == 1515936861 (0x5a5b5c5d)
[12:05:43]         0x5a5b5c5d6a6b6c6d == 6510899242581322861 (0x5a5b5c5d6a6b6c6d)
[12:05:43] legitimate get_user (u64) failed to do copy
[12:05:43] [FAILED] usercopy_test_valid

I can send a patch for that later,
but if you are on it anyways that would work for me, too.


> ---
> 
> Another quick fix to the sparc qemu_config I noticed while testing [1].
> 
> ---
>  tools/testing/kunit/qemu_configs/sparc.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/kunit/qemu_configs/sparc.py b/tools/testing/kunit/qemu_configs/sparc.py
> index 3131dd299a6e..2019550a1b69 100644
> --- a/tools/testing/kunit/qemu_configs/sparc.py
> +++ b/tools/testing/kunit/qemu_configs/sparc.py
> @@ -2,6 +2,7 @@ from ..qemu_config import QemuArchParams
>  
>  QEMU_ARCH = QemuArchParams(linux_arch='sparc',
>  			   kconfig='''
> +CONFIG_KUNIT_FAULT_TEST=n
>  CONFIG_SPARC32=y
>  CONFIG_SERIAL_SUNZILOG=y
>  CONFIG_SERIAL_SUNZILOG_CONSOLE=y
> -- 
> 2.49.0.604.gff1f9ca942-goog
>