linux-kernel - Re: [PATCH net-next 1/3] net: stmmac: dwmac-loongson: Move queue number init to common function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H6QEBvQWDkJHxba=TRr_Y7L57gqcZYWE9p-SHkyX0S3kg@mail.gmail.com>
Date: Wed, 16 Apr 2025 18:12:41 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Yanteng Si <si.yanteng@...ux.dev>, 
	Feiyang Chen <chris.chenfeiyang@...il.com>, loongarch@...ts.linux.dev, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Biao Dong <dongbiao@...ngson.cn>, Baoqi Zhang <zhangbaoqi@...ngson.cn>
Subject: Re: [PATCH net-next 1/3] net: stmmac: dwmac-loongson: Move queue
 number init to common function

On Tue, Apr 15, 2025 at 10:49 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Tue, Apr 15, 2025 at 03:11:26PM +0800, Huacai Chen wrote:
> > Currently, the tx and rx queue number initialization is duplicated in
> > loongson_gmac_data() and loongson_gnet_data(), so move it to the common
> > function loongson_default_data().
> >
> > This is a preparation for later patches.
> >
> > Tested-by: Biao Dong <dongbiao@...ngson.cn>
> > Signed-off-by: Baoqi Zhang <zhangbaoqi@...ngson.cn>
> > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> > ---
> >  .../ethernet/stmicro/stmmac/dwmac-loongson.c  | 39 +++++--------------
> >  1 file changed, 9 insertions(+), 30 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > index 1a93787056a7..f5fdef56da2c 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > @@ -83,6 +83,9 @@ struct stmmac_pci_info {
> >  static void loongson_default_data(struct pci_dev *pdev,
> >                                 struct plat_stmmacenet_data *plat)
> >  {
> > +     int i;
> > +     struct loongson_data *ld = plat->bsp_priv;
>
> Reverse Christmas tree please. Longest first, shortest last.
OK, I think it is better to move "int i" to the for-loop.

Huacai

>
>     Andrew
>
> ---
> pw-bot: cr
>
>