linux-kernel - Re: [PATCH] fs: gfs: Delete duplicate function generic_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78895df2-fb5a-4dd9-849e-91930419fac1@redhat.com>
Date: Wed, 16 Apr 2025 12:09:07 +0100
From: Andrew Price <anprice@...hat.com>
To: Chaohai Chen <wdhh6@...yun.com>, agruenba@...hat.com
Cc: gfs2@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: gfs: Delete duplicate function generic_update_time
 calls

On 16/04/2025 10:42, Chaohai Chen wrote:
> generic_update_time is called by inode_update_time after
> processing gfs2_update_time function,

This is incorrect. inode_update_time() returns after calling 
gfs2_update_time():

          if (inode->i_op->update_time)
                  return inode->i_op->update_time(inode, flags);
          generic_update_time(inode, flags);

Andy

> gfs2_update_time do not
> need call the generic_update_time again.
> 
> Signed-off-by: Chaohai Chen <wdhh6@...yun.com>
> ---
>   fs/gfs2/inode.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 6fbbaaad1cd0..05fc363bd6e7 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -2171,7 +2171,6 @@ static int gfs2_update_time(struct inode *inode, int flags)
>   		if (error)
>   			return error;
>   	}
> -	generic_update_time(inode, flags);
>   	return 0;
>   }
>