linux-kernel - Re: [PATCH 2/2] arm64: dts: ti: k3-j721s2: Add GPU node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416112700.t3zqihsmn24jaiub@purse>
Date: Wed, 16 Apr 2025 06:27:00 -0500
From: Nishanth Menon <nm@...com>
To: Randolph Sapp <rs@...com>
CC: Matt Coster <matt.coster@...tec.com>,
        Vignesh Raghavendra
	<vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Frank Binns
	<frank.binns@...tec.com>,
        Alessio Belle <alessio.belle@...tec.com>,
        Alexandru
 Dadu <alexandru.dadu@...tec.com>,
        Luigi Santivetti
	<luigi.santivetti@...tec.com>,
        Darren Etheridge <detheridge@...com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j721s2: Add GPU node

On 15:29-20250415, Randolph Sapp wrote:
> On Tue Apr 15, 2025 at 11:20 AM CDT, Matt Coster wrote:
> > The J721S2 binding is based on the TI downstream binding in commit
> > 54b0f2a00d92 ("arm64: dts: ti: k3-j721s2-main: add gpu node") from [1]
> > but with updated compatible strings.
> >
> > The clock[2] and power[3] indices were verified from docs, but the
> > source of the interrupt index remains elusive.
> >
> 
> For future reference, interrupt maps are present in the TRM. "Table 6-89. GPU0
> Hardware Requests" explicitly calls it out "GPU0 | GPU0_MISC_0_IRQ_0 |
> GIC500_SPI_IN_56 | COMPUTE_CLUSTER0 | GPU0 interrupt request". Subtract 32 from
> that pin number to get the DT number.

Now that the mystery is resolved, could we update the commit message?
> 
> That comment aside, this series seems fine to me.
> Reviewed-by: Randolph Sapp <rs@...com>
> 
> > [1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel
> > [2]: https://downloads.ti.com/tisci/esd/latest/5_soc_doc/j721s2/clocks.html
> > [3]: https://downloads.ti.com/tisci/esd/latest/5_soc_doc/j721s2/devices.html
> >
> > Signed-off-by: Matt Coster <matt.coster@...tec.com>
> > ---
> > This patch was previously sent as [DO NOT MERGE]:
> > https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-18-eda620c5865f@imgtec.com
> > ---
> >  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > index 92bf48fdbeba45ecca8c854db5f72fd3666239c5..a79ac41b2c1f51b7193e6133864428bd35a5e835 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > @@ -2048,4 +2048,16 @@ watchdog8: watchdog@...0000 {
> >  		/* reserved for MAIN_R5F1_1 */
> >  		status = "reserved";
> >  	};
> > +
> > +	gpu: gpu@...0000000 {
> > +		compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";
> > +		reg = <0x4e 0x20000000 0x00 0x80000>;
> > +		clocks = <&k3_clks 130 1>;
> > +		clock-names = "core";
> > +		interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> > +		power-domains = <&k3_pds 130 TI_SCI_PD_EXCLUSIVE>,
> > +				<&k3_pds 373 TI_SCI_PD_EXCLUSIVE>;
> > +		power-domain-names = "a", "b";
> > +		dma-coherent;
> > +	};
> >  };
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D