linux-kernel - Re: [PATCH 2/2] arm64: dts: freescale: add initial device tree for TQMa8XxS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4975795.GXAFRqVoOG@steina-w>
Date: Wed, 16 Apr 2025 13:53:52 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Magnus Damm <magnus.damm@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux@...tq-group.com,
 linux-renesas-soc@...r.kernel.org
Subject:
 Re: [PATCH 2/2] arm64: dts: freescale: add initial device tree for TQMa8XxS

Hi Andrew,

Am Dienstag, 15. April 2025, 17:27:37 CEST schrieb Andrew Lunn:
> > +&fec1 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_fec1>;
> > +	phy-mode = "rgmii-id";
> > +	phy-handle = <&ethphy0>;
> > +	fsl,magic-packet;
> > +	mac-address = [ 00 00 00 00 00 00 ];
> > +
> > +	mdio {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		ethphy0: ethernet-phy@0 {
> > +			compatible = "ethernet-phy-ieee802.3-c22";
> > +			reg = <0>;
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&pinctrl_ethphy0>;
> > +			ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
> > +			ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
> > +			ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> > +			ti,dp83867-rxctrl-strap-quirk;
> > +			ti,clk-output-sel = <DP83867_CLK_O_SEL_OFF>;
> > +			reset-gpios = <&lsio_gpio3 22 GPIO_ACTIVE_LOW>;
> > +			reset-assert-us = <500000>;
> > +			reset-deassert-us = <50000>;
> > +			enet-phy-lane-no-swap;
> > +			interrupt-parent = <&lsio_gpio1>;
> > +			interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
> 
> EDGE_FALLING is very likely to be wrong. PHYs are generally level
> triggered, not edge.

Thanks for that comment. I checked with my colleagues and it is
indeed level-low. Will fix in v2.

Thanks
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/