linux-kernel - Re: [PATCH 15/16] misc: lan966x_pci: Add dtso nodes in order to support SFPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97cf068f-3770-4df9-a60a-30761ffcb03d@lunn.ch>
Date: Wed, 16 Apr 2025 14:05:49 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Peter Rosin <peda@...ntia.se>,
	Derek Kiernan <derek.kiernan@....com>,
	Dragan Cvetic <dragan.cvetic@....com>,
	Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Mark Brown <broonie@...nel.org>, Len Brown <lenb@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Wolfram Sang <wsa@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-acpi@...r.kernel.org,
	Allan Nielsen <allan.nielsen@...rochip.com>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>,
	Steen Hegelund <steen.hegelund@...rochip.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>
Subject: Re: [PATCH 15/16] misc: lan966x_pci: Add dtso nodes in order to
 support SFPs

On Wed, Apr 16, 2025 at 11:18:19AM +0200, Herve Codina wrote:
> Hi Thomas, Andrew,
> 
> On Thu, 10 Apr 2025 08:48:09 +0200
> Thomas Petazzoni <thomas.petazzoni@...tlin.com> wrote:
> 
> > On Wed, 9 Apr 2025 17:03:45 +0200
> > Andrew Lunn <andrew@...n.ch> wrote:
> > 
> > > So it only supports a single .dtbo. In its current form it does not
> > > scale to multiple .dtso files for multiple different boards built
> > > around the PCIe chip.
> > > 
> > > At the moment, that is not really an issue, but when the second board
> > > comes along, some refactoring will be needed.  
> > 
> > Indeed, but that's really an implementation detail. It doesn't change
> > anything to the overall approach. The only thing that would have to
> > change is how the driver gets the .dtbo. We could bundle several .dtbos
> > in the driver, we could fall back to request_firmware(), etc.
> > 
> 
> Not sure we need to split right now the existing dtso file nor rename it
> even if it is updated in the series.
> 
> This could be done later when an other user of the LAN996x PCI chip is
> there.
> 
> Doing something right now will probably need other modification when this
> potential other user comes in. Indeed, depending on specificities of this
> future user, what is done now could not match the need of this future user.
> 
> Any opinion?

I agree support for multiple .dtso can be done later.

But i would do the split between the .dtsi file for the PCIe device,
and the .dtso file for the board now. That is a pretty fundamental
concept in Linux DT support.

	Andrew