linux-kernel - Re: [PATCH next] drm/udl: Set error code in udl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9cd4d99-82f5-44d3-950d-2a4040875e24@suse.de>
Date: Wed, 16 Apr 2025 14:06:21 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Dave Airlie <airlied@...hat.com>, Sean Paul <sean@...rly.run>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm/udl: Set error code in udl_init()

Hi,

thanks for the fix.

Am 16.04.25 um 13:09 schrieb Dan Carpenter:
> Return -ENOMEM if udl_alloc_urb_list() fails.  Don't return success.
>
> Fixes: fb10144ba426 ("drm/udl: Support adapters without firmware descriptor")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/gpu/drm/udl/udl_main.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index 3dfeb88cf918..bc58991a6f14 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -361,6 +361,7 @@ int udl_init(struct udl_device *udl)
>   
>   	if (!udl_alloc_urb_list(udl, WRITES_IN_FLIGHT, MAX_TRANSFER)) {
>   		DRM_ERROR("udl_alloc_urb_list failed\n");
> +		ret = -ENOMEM;
>   		goto err;
>   	}
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)