linux-kernel - Re: [PATCH v1 1/1] i2c: designware: Use better constants from units.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf67e195-cb7f-4474-9f93-96030fe76e12@quicinc.com>
Date: Wed, 16 Apr 2025 17:49:42 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andi Shyti
	<andi.shyti@...nel.org>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg
	<mika.westerberg@...ux.intel.com>,
        Jan Dabros <jsd@...ihalf.com>
Subject: Re: [PATCH v1 1/1] i2c: designware: Use better constants from units.h



On 4/16/2025 3:47 PM, Andy Shevchenko wrote:
> When we use constants in a time or frequency related contexts,
> it's better to utilise the respective definitions that have
> encoded units in them. This will make code better to read and
> understand.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index d6e1ee935399..879719e91df2 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -34,7 +34,7 @@
>   
>   static u32 i2c_dw_get_clk_rate_khz(struct dw_i2c_dev *dev)
>   {
> -	return clk_get_rate(dev->clk) / KILO;
> +	return clk_get_rate(dev->clk) / HZ_PER_KHZ;
>   }
>   
>   #ifdef CONFIG_OF
Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>