linux-kernel - [PATCH] of: Build warn for missing fn() in _OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tencent_BA80A2305727877DEE7BE20655D9CA825B09@qq.com>
Date: Thu, 17 Apr 2025 21:23:38 +0800
From: Liya Huang <1425075683@...com>
To: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Liya Huang <1425075683@...com>
Subject: [PATCH] of: Build warn for missing fn() in _OF_DECLARE

The function pointer fn() in _OF_DECLARE macro might be NULL. For example,
in __reserved_mem_init_node(), only non-NULL cases are handled, and NULL
function pointers are ignored.

This patch introduces a check to handle cases where fn() is NULL. If fn()
is found to be NULL, a warning is issued during compilation to notify
developers about the missing function pointer.

---
The function pointer fn() in _OF_DECLARE macro might be NULL. For example,
in __reserved_mem_init_node(), only non-NULL cases are handled, and NULL
function pointers are ignored.

This patch introduces a check to handle cases where fn() is NULL. If fn()
is found to be NULL, a warning is issued during compilation to notify 
developers about the missing function pointer.

Link: https://lore.kernel.org/all/CAL_JsqK733Q9bbxC0Wz5uxyZ9m7bs+bci5kUJF9GJMv73-dO4w@mail.gmail.com/

Signed-off-by: Liya Huang <1425075683@...com>
---
 include/linux/of.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index a62154aeda1b6a600c2b155ac486c0e0b56e0bf2..99d1d553e65b7970a3ecb5158774ca5185f297a0 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -1523,6 +1523,7 @@ static inline int of_get_available_child_count(const struct device_node *np)
 }
 
 #define _OF_DECLARE_STUB(table, name, compat, fn, fn_type)		\
+	static_assert((fn) != NULL);	\
 	static const struct of_device_id __of_table_##name		\
 		__attribute__((unused))					\
 		 = { .compatible = compat,				\
@@ -1530,6 +1531,7 @@ static inline int of_get_available_child_count(const struct device_node *np)
 
 #if defined(CONFIG_OF) && !defined(MODULE)
 #define _OF_DECLARE(table, name, compat, fn, fn_type)			\
+	static_assert((fn) != NULL);	\
 	static const struct of_device_id __of_table_##name		\
 		__used __section("__" #table "_of_table")		\
 		__aligned(__alignof__(struct of_device_id))		\

---
base-commit: 8ffd015db85fea3e15a77027fda6c02ced4d2444
change-id: 20250417-_of_declare-ac80b59d952d

Best regards,
-- 
Liya Huang <1425075683@...com>