linux-kernel - Re: [PATCH -next] usb: typec: ucsi: Fix unmet dependencies for UCSI_HUAWEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAEFz_Jf8aqgzBcY@kuha.fi.intel.com>
Date: Thu, 17 Apr 2025 16:44:47 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: gregkh@...uxfoundation.org, mitltlatltl@...il.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] usb: typec: ucsi: Fix unmet dependencies for
 UCSI_HUAWEI_GAOKUN

On Thu, Apr 17, 2025 at 08:28:43PM +0800, Yue Haibing wrote:
> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>   Depends on [n]: HAS_IOMEM [=y] && DRM [=n] && DRM_BRIDGE [=n] && OF [=n]
>   Selected by [m]:
>   - UCSI_HUAWEI_GAOKUN [=m] && USB_SUPPORT [=y] && TYPEC [=m] && TYPEC_UCSI [=m] && EC_HUAWEI_GAOKUN [=m]
> 
> DRM_AUX_HPD_BRIDGE depends on DRM_BRIDGE and OF, only select it with
> both for UCSI_HUAWEI_GAOKUN.
> 
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/ucsi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> index e94956d27325..8bf8fefb4f07 100644
> --- a/drivers/usb/typec/ucsi/Kconfig
> +++ b/drivers/usb/typec/ucsi/Kconfig
> @@ -94,7 +94,7 @@ config UCSI_LENOVO_YOGA_C630
>  config UCSI_HUAWEI_GAOKUN
>  	tristate "UCSI Interface Driver for Huawei Matebook E Go"
>  	depends on EC_HUAWEI_GAOKUN
> -	select DRM_AUX_HPD_BRIDGE
> +	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
>  	help
>  	  This driver enables UCSI support on the Huawei Matebook E Go tablet,
>  	  which is a sc8280xp-based 2-in-1 tablet.
> -- 
> 2.34.1

-- 
heikki