linux-kernel - Re: [PATCH] mseal sysmap: enable mips with LOONGSON64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dpagj64oai5yn45poxfr36jtliwpbueu3pvhbrb5flxgu7hnql@7rarpfgkf6wz>
Date: Thu, 17 Apr 2025 15:27:16 +0100
From: Pedro Falcato <pfalcato@...e.de>
To: WangYuli <wangyuli@...ontech.com>
Cc: corbet@....net, tsbogend@...ha.franken.de, akpm@...ux-foundation.org, 
	jeffxu@...omium.org, lorenzo.stoakes@...cle.com, kees@...nel.org, 
	Liam.Howlett@...cle.com, hca@...ux.ibm.com, takumaw1990@...il.com, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, 
	thomas.weissschuh@...utronix.de, tglx@...utronix.de, namcao@...utronix.de, zhanjun@...ontech.com, 
	niecheng1@...ontech.com, guanwentao@...ontech.com, Erpeng Xu <xuerpeng@...ontech.com>
Subject: Re: [PATCH] mseal sysmap: enable mips with LOONGSON64

On Thu, Apr 17, 2025 at 09:24:10PM +0800, WangYuli wrote:
> Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on mips with
> CPU_LOONGSON64, covering the vdso.
> 
> NOTE:
>   There is significant diversity among devices within the MIPS
> architecture, which extends to their kernel code implementations.
>   My testing capabilities are limited to Loongson 3A4000/3B4000
> CPUs.
>   Consequently, I have not enabled mseal sysmap support for the
> entirety of mips64, as I lack the necessary devices for testing.
>

I strongly suggest we don't do this kind of stuff. Lets keep things simple and either:

1) Check that there's no problem for _all_ variations of the arch. Then enable
   ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS.
2) If not checking everything, then don't do any sort of enabling.

It should help reduce confusion.

And, to be clear for folks not following mseal, this feature is rather small and not a
priority in any way (and will not be enabled in linux distros for a whole bunch of years,
due to the current situation being unworkable for !chromeOS). There's really no rush
in having this enabled for all architectures.

-- 
Pedro