linux-kernel - Re: [PATCH v2] dt-bindings: leds: Allow differently named multicolor leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAERoxkLoB_HwGFR@probook>
Date: Thu, 17 Apr 2025 14:35:15 +0000
From: J. Neuschäfer <j.ne@...teo.net>
To: Rob Herring <robh@...nel.org>
Cc: J. Neuschäfer <j.ne@...teo.net>,
	Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
	Pavel Machek <pavel@...nel.org>, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2] dt-bindings: leds: Allow differently named multicolor
 leds

On Sat, Apr 12, 2025 at 12:12:37PM -0500, Rob Herring wrote:
> On Sat, Apr 12, 2025 at 03:04:32PM +0200, J. Neuschäfer wrote:
> > In some cases, for example when using multiple instances of
> > leds-group-multicolor, a board may have multiple multi-leds which can't
> > be distinguished by unit address. In such cases it should be possible to
> > name them differently, for example multi-led-a and multi-led-b. This
> > patch adds another node name pattern to leds-class-multicolor.yaml to
> > allow such names.
> 
> Really, multi-led-0, multi-led-1, etc. would be preferred like we have 
> in other places.

I'll change the examples to -0, -1. I'm also open to restricting the
pattern to something else than -.+

> 
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> > ---
> > V2:
> > - Add Krzysztof's review tag
> > - mention leds-group-multicolor in the commit message
> > - rebase on 6.15-rc1
> > 
> > Link to v1: https://lore.kernel.org/r/20250209-multi-led-v1-1-5aebccbd2db7@posteo.net
> > ---
> >  Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> > index bb40bb9e036ee00e06d21e2321ecd5a7d471c408..c22af25b6430be71300c0e37f696cd61112ea190 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> > @@ -21,7 +21,9 @@ description: |
> >  
> >  properties:
> >    $nodename:
> > -    pattern: "^multi-led(@[0-9a-f])?$"
> > +    oneOf:
> > +      - pattern: "^multi-led(@[0-9a-f])?$"
> > +      - pattern: "^multi-led-.*$"
> 
> Combine these:
> 
> '^multi-led(-.+|@[0-9a-f])?$'
> 
> oneOf is best avoided because the error messages aren't so great.

Alright, I'll change that.

> 
> >  
> >    color:
> >      description: |
> > 
> > ---
> > base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> > change-id: 20250209-multi-led-9991e205befd
> > 
> > Best regards,
> > -- 
> > J. Neuschäfer <j.ne@...teo.net>
> >