linux-kernel - Re: [PATCH 1/4] configfs: Delete semicolon from macro type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6633a15-0175-4fc0-ab84-14092f84ce43@icloud.com>
Date: Thu, 17 Apr 2025 22:47:40 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Joel Becker <jlbec@...lplan.org>,
 Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
 Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH 1/4] configfs: Delete semicolon from macro type_print()
 definition

On 2025/4/17 22:38, Breno Leitao wrote:
> Hello Zijun,
> 
> On Tue, Apr 08, 2025 at 09:26:07PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> Macro type_print() definition ends with semicolon, so will cause
>> the subsequent macro invocations end with two semicolons.
> 
> where is the type_print() macro invoked today?
> 
> I haven't found any reference for it in fs/configfs/dir.c
> 

both its definition and invocations are within

fs/configfs/dir.c:
static void configfs_dump_one(struct configfs_dirent *sd, int level)
{
        pr_info("%*s\"%s\":\n", level, " ", configfs_get_name(sd));

#define type_print(_type) if (sd->s_type & _type) pr_info("%*s %s\n",
level, " ", #_type);
        type_print(CONFIGFS_ROOT);
        type_print(CONFIGFS_DIR);
        type_print(CONFIGFS_ITEM_ATTR);
        type_print(CONFIGFS_ITEM_LINK);
        type_print(CONFIGFS_USET_DIR);
        type_print(CONFIGFS_USET_DEFAULT);
        type_print(CONFIGFS_USET_DROPPING);
#undef type_print
}

configfs_dump_one() is invoked by

> Thanks
> --breno