linux-kernel - Re: [PATCH v2 2/3] configfs: Do not override creating attribute file failure in populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAEWyoqVFEknPSbH@gmail.com>
Date: Thu, 17 Apr 2025 07:57:14 -0700
From: Breno Leitao <leitao@...ian.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Joel Becker <jlbec@...lplan.org>,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
	Zijun Hu <quic_zijuhu@...cinc.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/3] configfs: Do not override creating attribute file
 failure in populate_attrs()

On Tue, Apr 15, 2025 at 08:34:26PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> populate_attrs() may override failure for creating attribute files
> by success for creating subsequent bin attribute files, and have
> wrong return value.
> 
> Fix by creating bin attribute files under successfully creating
> attribute files.
> 
> Fixes: 03607ace807b ("configfs: implement binary attributes")
> Cc: stable@...r.kernel.org
> Reviewed-by: Joel Becker <jlbec@...lplan.org>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>

Reviewed-by: Breno Leitao <leitao@...ian.org>