linux-kernel - Re: [PATCH v2 1/3] configfs: Delete semicolon from macro type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CDCE55D6-2296-4B36-9A65-369EC13492DC@icloud.com>
Date: Thu, 17 Apr 2025 23:11:10 +0800
From: huzijun <zijun_hu@...oud.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Joel Becker <jlbec@...lplan.org>,
 Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
 Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2 1/3] configfs: Delete semicolon from macro type_print() definition


> 在 2025年4月17日，22:58，Breno Leitao <leitao@...ian.org> 写道：
> 
> On Tue, Apr 15, 2025 at 08:34:25PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>> 
>> Macro type_print() definition ends with semicolon, so will cause
>> the subsequent macro invocations end with two semicolons.
>> 
>> Fix by deleting the semicolon from the macro definition.
>> 
>> Reviewed-by: Joel Becker <jlbec@...lplan.org>
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
>> ---
>> fs/configfs/dir.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
>> index 7d10278db30d667d0ef7e1140e54961c5a440c41..0a011bdad98c492227859ff328d61aeed2071e24 100644
>> --- a/fs/configfs/dir.c
>> +++ b/fs/configfs/dir.c
>> @@ -970,7 +970,7 @@ static void configfs_dump_one(struct configfs_dirent *sd, int level)
>> {
>>    pr_info("%*s\"%s\":\n", level, " ", configfs_get_name(sd));
>> 
>> -#define type_print(_type) if (sd->s_type & _type) pr_info("%*s %s\n", level, " ", #_type);
>> +#define type_print(_type) if (sd->s_type & _type) pr_info("%*s %s\n", level, " ", #_type)
>>    type_print(CONFIGFS_ROOT);
>>    type_print(CONFIGFS_DIR);
>>    type_print(CONFIGFS_ITEM_ATTR);
> 
> As I've asked in V1. Is this macro being used?
> 
yes. it is being used by those 3 statements which follows the macro definition (^^)
> --breno