linux-kernel - Re: [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174490312803.238725.14116695966907460215.b4-ty@kernel.org>
Date: Thu, 17 Apr 2025 20:48:48 +0530
From: Vinod Koul <vkoul@...nel.org>
To: nathan.lynch@....com, Basavaraj.Natikar@....com, 
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Eder Zulian <ezulian@...hat.com>
Subject: Re: [PATCH v2] dmaengine: ptdma: Remove unused pointer
 dma_cmd_cache


On Tue, 15 Apr 2025 14:13:12 +0200, Eder Zulian wrote:
> The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
> 'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
> resource")' but it was never used.
> 
> Changes since v1:
> - Remove the 'err_cache' label and return -ENOMEM directly instead of
>   assigning -ENOMEM to 'ret' and jumping to the label, since there
>   are no unmanaged allocations to unwind. Based on suggestion from
>   Nathan Lynch.
> - Fix checkpatch.pl error: ERROR: Please use git commit description style
>   'commit <12+ chars of sha1> ("<title line>")'
> 
> [...]

Applied, thanks!

[1/1] dmaengine: ptdma: Remove unused pointer dma_cmd_cache
      commit: f087965ab4aaca653d19ea3909b42e7ef2b64ba0

Best regards,
-- 
~Vinod