linux-kernel - Re: [PATCH] ipmi:si: Move SI type information into an info structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAEfb3y7fCnvPc_F@smile.fi.intel.com>
Date: Thu, 17 Apr 2025 18:34:07 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Z_6uzH9DsWIh-hIz@...l.minyard.net
Cc: Linux Kernel <linux-kernel@...r.kernel.org>,
	OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>
Subject: Re: [PATCH] ipmi:si: Move SI type information into an info structure

On Wed, Apr 16, 2025 at 08:45:51PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 16, 2025 at 07:09:12AM -0500, Corey Minyard wrote:
> > Andy reported:
> > 
> > Debian clang version 19.1.7 is not happy when compiled with
> > `make W=1` (note, CONFIG_WERROR=y is the default):
> > 
> > ipmi_si_platform.c:268:15: error: cast to smaller integer type 'enum si_type'
> > +from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
> >   268 |         io.si_type      = (enum
> > +si_type)device_get_match_data(&pdev->dev);
> > 
> > The IPMI SI type is an enum that was cast into a pointer that was
> > then cast into an enum again.  That's not the greatest style, so
> > instead create an info structure to hold the data and use that.
> 
> I'm going to test this today or latest tomorrow, below some comments.

I have noticed the commit 37631eee2063 ("ipmi:si: Move SI type information into
an info structure") which is in Linux Next and it compiles for me as expected,
thank you for the prompt fix!

-- 
With Best Regards,
Andy Shevchenko