linux-kernel - Re: [PATCH v3 02/10] pinctrl: core: add devm_pinctrl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAEoq6t8Tnts1eFY@smile.fi.intel.com>
Date: Thu, 17 Apr 2025 19:13:31 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	thomas.petazzoni@...tlin.com, DanieleCleri@...on.eu,
	GaryWang@...on.com.tw
Subject: Re: [PATCH v3 02/10] pinctrl: core: add
 devm_pinctrl_register_mappings()

On Wed, Apr 16, 2025 at 04:08:10PM +0200, Thomas Richard wrote:
> Using devm_pinctrl_register_mappings(), the core can automatically
> unregister pinctrl mappings.

...

> +int devm_pinctrl_register_mappings(struct device *dev,
> +				   const struct pinctrl_map *maps,
> +				   unsigned int num_maps)
> +{
> +	const struct pinctrl_map **ptr;
> +	int ret;
> +
> +	ptr = devres_alloc(devm_pinctrl_unregister_mappings, sizeof(*ptr),
> +			   GFP_KERNEL);
> +	if (!ptr)
> +		return -ENOMEM;
> +
> +	ret = pinctrl_register_mappings(maps, num_maps);
> +	if (!ret) {
> +		*ptr = maps;
> +		devres_add(dev, ptr);
> +	} else {
> +		devres_free(ptr);
> +	}
> +
> +	return ret;

Why not devm_add_action_or_reset()?

> +}

...

>  extern int pinctrl_register_mappings(const struct pinctrl_map *map,
>  				     unsigned int num_maps);
> +extern int devm_pinctrl_register_mappings(struct device *dev,
> +					  const struct pinctrl_map *map,
> +					  unsigned int num_maps);

No extern, please. Perhaps a clean up patch to remove existing ones?

>  extern void pinctrl_unregister_mappings(const struct pinctrl_map *map);
>  extern void pinctrl_provide_dummies(void);

...

Test robot wants you to add a forward declaration

struct device;


-- 
With Best Regards,
Andy Shevchenko