linux-kernel - Re: [PATCH] cgroup: Fix compilation issue due to cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7cf14f0-213f-4e15-abe8-cc09a293c4fc@oracle.com>
Date: Thu, 17 Apr 2025 21:46:00 +0530
From: Kamalesh Babulal <kamalesh.babulal@...cle.com>
To: gaoxu <gaoxu2@...or.com>, Tejun Heo <tj@...nel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Koutný
 <mkoutny@...e.com>
Cc: "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "surenb@...gle.com" <surenb@...gle.com>,
        yipengxiang <yipengxiang@...or.com>
Subject: Re: [PATCH] cgroup: Fix compilation issue due to cgroup_mutex not
 being exported



On 4/17/25 1:00 PM, gaoxu wrote:
[...]

> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 447ac857e..9e60ff629 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -90,7 +90,7 @@
>  DEFINE_MUTEX(cgroup_mutex);
>  DEFINE_SPINLOCK(css_set_lock);
>  
> -#ifdef CONFIG_PROVE_RCU
> +#if (defined CONFIG_PROVE_RCU || defined CONFIG_LOCKDEP)
>  EXPORT_SYMBOL_GPL(cgroup_mutex);
>  EXPORT_SYMBOL_GPL(css_set_lock);
>  #endif


It can be triggered when CONFIG_LOCK_STAT=y is enabled, which
selects CONFIG_LOCKDEP=y and sets CONFIG_PROVE_RCU=n. The patch
looks good to me.

You may also want to update the description above DEFINE_MUTEX(cgroup_mutex);
to reflect the modifications introduced by this patch.

-- 
Cheers,
Kamalesh