linux-kernel - RE: [EXT] [PATCH] spi: spi-imx: Add check for spi_imx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <VI2PR04MB111477C8C199A1110FF0BBCB6E8BC2@VI2PR04MB11147.eurprd04.prod.outlook.com>
Date: Thu, 17 Apr 2025 01:39:33 +0000
From: Carlos Song <carlos.song@....com>
To: Tamura Dai <kirinode0@...il.com>, Mark Brown <broonie@...nel.org>, Shawn
 Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>
CC: "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] spi: spi-imx: Add check for spi_imx_setupxfer()


Hi, Thank you for fix.

Reviewed-by: Carlos Song <carlos.song@....com>

> -----Original Message-----
> From: Tamura Dai <kirinode0@...il.com>
> Sent: Thursday, April 17, 2025 9:16 AM
> To: Mark Brown <broonie@...nel.org>; Shawn Guo <shawnguo@...nel.org>;
> Sascha Hauer <s.hauer@...gutronix.de>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>
> Cc: linux-spi@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Tamura Dai
> <kirinode0@...il.com>
> Subject: [EXT] [PATCH] spi: spi-imx: Add check for spi_imx_setupxfer()
> 
> [You don't often get email from kirinode0@...il.com. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Add check for the return value of spi_imx_setupxfer().
> spi_imx->rx and spi_imx->tx function pointer can be NULL when
> spi_imx_setupxfer() return error, and make NULL pointer dereference.
> 
>  Unable to handle kernel NULL pointer dereference at virtual address
> 0000000000000000  Call trace:
>   0x0
>   spi_imx_pio_transfer+0x50/0xd8
>   spi_imx_transfer_one+0x18c/0x858
>   spi_transfer_one_message+0x43c/0x790
>   __spi_pump_transfer_message+0x238/0x5d4
>   __spi_sync+0x2b0/0x454
>   spi_write_then_read+0x11c/0x200
> 
> Signed-off-by: Tamura Dai <kirinode0@...il.com>
> ---
>  drivers/spi/spi-imx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index
> 832d6e9009eb..c93d80a4d734 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -1695,9 +1695,12 @@ static int spi_imx_transfer_one(struct
> spi_controller *controller,
>                                 struct spi_device *spi,
>                                 struct spi_transfer *transfer)  {
> +       int ret;
>         struct spi_imx_data *spi_imx =
> spi_controller_get_devdata(spi->controller);
> 
> -       spi_imx_setupxfer(spi, transfer);
> +       ret = spi_imx_setupxfer(spi, transfer);
> +       if (ret < 0)
> +               return ret;
>         transfer->effective_speed_hz = spi_imx->spi_bus_clk;
> 
>         /* flush rxfifo before transfer */
> --
> 2.47.2
>