linux-kernel - Re: [PATCH v3 07/17] x86/mce: Define BSP-only init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250417021835.GNaABk-wGduDVt_q41@fat_crate.local>
Date: Thu, 17 Apr 2025 04:18:35 +0200
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: x86@...nel.org, Tony Luck <tony.luck@...el.com>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	Smita.KoralahalliChannabasappa@....com,
	Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Subject: Re: [PATCH v3 07/17] x86/mce: Define BSP-only init

On Tue, Apr 15, 2025 at 02:55:02PM +0000, Yazen Ghannam wrote:
> +/* Called only on the boot CPU. */
> +void cpu_mca_init(struct cpuinfo_x86 *c)

I guess mca_bsp_init() or mca_init() or so. Probably former as the name makes
it perfectly clear and obviates the need for the comment above.

Because there's also mcheck_cpu_init() which is per-CPU and that's confusion
waiting to happen.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette