linux-kernel - Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250417194456.GA10777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Thu, 17 Apr 2025 12:44:56 -0700
From: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
To: Zhu Yanjun <yanjun.zhu@...ux.dev>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	longli@...rosoft.com, kotaranov@...rosoft.com, horms@...nel.org,
	kent.overstreet@...ux.dev, brett.creeley@....com,
	schakrabarti@...ux.microsoft.com, shradhagupta@...ux.microsoft.com,
	ssengar@...ux.microsoft.com, rosenp@...il.com,
	paulros@...rosoft.com, linux-hyperv@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH 1/3] net: mana: Add speed support in
 mana_get_link_ksettings

On Thu, Apr 17, 2025 at 03:38:26PM +0200, Zhu Yanjun wrote:
> On 17.04.25 09:57, Erni Sri Satya Vennela wrote:
> >Add support for speed in mana ethtool get_link_ksettings
> >operation. This feature is not supported by all hardware.
> >
> >Signed-off-by: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
> >Reviewed-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> >Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> >---
> >  drivers/net/ethernet/microsoft/mana/mana_en.c | 42 +++++++++++++++++++
> >  .../ethernet/microsoft/mana/mana_ethtool.c    |  6 +++
> >  include/net/mana/mana.h                       | 17 ++++++++
> >  3 files changed, 65 insertions(+)
> >
> >diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> >index 2bac6be8f6a0..ba550fc7ece0 100644
> >--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> >+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> >@@ -1156,6 +1156,48 @@ static int mana_cfg_vport_steering(struct mana_port_context *apc,
> >  	return err;
> >  }
> >+int mana_query_link_cfg(struct mana_port_context *apc)
> >+{
> >+	struct net_device *ndev = apc->ndev;
> >+	struct mana_query_link_config_resp resp = {};
> >+	struct mana_query_link_config_req req = {};
> >+	int err;
> >+
> >+	mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_LINK_CONFIG,
> >+			     sizeof(req), sizeof(resp));
> >+
> >+	req.vport = apc->port_handle;
> >+
> >+	err = mana_send_request(apc->ac, &req, sizeof(req), &resp,
> >+				sizeof(resp));
> >+
> >+	if (err) {
> >+		netdev_err(ndev, "Failed to query link config: %d\n", err);
> >+		goto out;
> >+	}
> >+
> >+	err = mana_verify_resp_hdr(&resp.hdr, MANA_QUERY_LINK_CONFIG,
> >+				   sizeof(resp));
> >+
> >+	if (err || resp.hdr.status) {
> >+		netdev_err(ndev, "Failed to query link config: %d, 0x%x\n", err,
> >+			   resp.hdr.status);
> >+		if (!err)
> >+			err = -EPROTO;
> 
> EPROTO means Protocol error. Thus, ENOTSUPP or EPROTONOSUPPORT is better?
> 
> Zhu Yanjun
Thank you for the suggestion, Zhu Yanjun. I will also make this change
in mana_set_bw_clamp(). This update will be included in the next version
of the patch.
> 
> >+		goto out;
> >+	}
> >+
> >+	if (resp.qos_unconfigured) {
> >+		err = -EINVAL;
> >+		goto out;
> >+	}
> >+	apc->speed = resp.link_speed_mbps;
> >+	return 0;
> >+
> >+out:
> >+	return err;
> >+}
> >+