linux-kernel - Re: [PATCH v4 2/5] i2c: piix4: Depends on X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8562d6b5-3b81-40e2-9cda-f202ab85d5a9@kernel.org>
Date: Thu, 17 Apr 2025 17:21:22 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>, Jean Delvare <jdelvare@...e.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Jonathan Corbet <corbet@....net>,
 Mario Limonciello <mario.limonciello@....com>,
 Yazen Ghannam <yazen.ghannam@....com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
 "H . Peter Anvin" <hpa@...or.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Hans de Goede <hdegoede@...hat.com>,
 "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC" <linux-i2c@...r.kernel.org>,
 "open list:AMD PMC DRIVER" <platform-driver-x86@...r.kernel.org>,
 kernel test robot <lkp@...el.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v4 2/5] i2c: piix4: Depends on X86

On 4/17/2025 5:16 PM, Andi Shyti wrote:
> Hi Mario,
> 
> On Mon, Apr 14, 2025 at 07:26:55PM -0500, Mario Limonciello wrote:
>> PIIX4 and compatible controllers are only for X86. As some headers are
>> being moved into x86 specific headers PIIX4 won't compile on non-x86.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202504120558.sq3IpWdH-lkp@intel.com/
>> Closes: https://lore.kernel.org/oe-kbuild-all/202504120432.0F8lOF3k-lkp@intel.com/
> 
> givent that the next patch is not merged anywhere yet, the above
> three tags are not needed.

Ah, thanks for clarifying this.  I'll strip them for the next version.

> 
> BTW, can I already take the two i2c patches?

If you don't mind I think it would be better to leave Acked-by tags for 
them and let these go through tip.

A few reasons:
1) The header rename this fits into happened on tip already.
2) Patch 5 which would go through tip depends on these two patches, so 
it would mean you need to provide an immutable branch for tip to merge.

But if you would rather do the immutable branch dance and take them now 
that's of course possible too.

> 
> Thanks,
> Andi
> 
>> Suggested-by: Ingo Molnar <mingo@...nel.org>
>> Signed-off-by: Mario Limonciello <mario.limonciello@....com>