linux-kernel - Re: [PATCH v2 2/2] dt-bindings: mmc: sdhci-am654: Add ti,suppress-v1p8-ena

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b051466d-534d-4e93-9ba5-52401aed82ef@ti.com>
Date: Thu, 17 Apr 2025 17:37:15 -0500
From: Judith Mendez <jm@...com>
To: Francesco Dolcini <francesco@...cini.it>
CC: Ulf Hansson <ulf.hansson@...aro.org>,
        Adrian Hunter
	<adrian.hunter@...el.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-mmc@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Josua Mayer <josua@...id-run.com>, Moteen
 Shah <m-shah@...com>,
        Hiago De Franco <hiagofranco@...il.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: mmc: sdhci-am654: Add
 ti,suppress-v1p8-ena

Hi Francesco,

On 4/17/25 2:19 PM, Francesco Dolcini wrote:
> Hello Judith,
> thanks for the patch.
> 
> On Thu, Apr 17, 2025 at 01:26:52PM -0500, Judith Mendez wrote:
>> This patch documents ti,suppress-v1p8-ena which is a flag
>> used to suppress V1P8_SIGNAL_ENA in sdhci_am654 driver. This
>> quirk is necessary to fix fail init issues across various
>> types of SD cards tested on Sitara K3 SoCs.
> 
> bindings are supposed to describe the hardware, not the driver.
> 
> You should rephrase the commit message and the description of the property with
> this in mind.
> 
> In addition, I think that the dt-bindings is supposed to be before the driver
> patch in the series.
> 

Right, will fix for v3 along with adding fixes tags.

~ Judith