linux-kernel - Re: [PATCH] tracing: Fix filter string testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250417162927.e1117ce02e612e29a34985ef@linux-foundation.org>
Date: Thu, 17 Apr 2025 16:29:27 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrii Nakryiko <andrii.nakryiko@...il.com>, Mykyta Yatsenko
 <mykyta.yatsenko5@...il.com>
Subject: Re: [PATCH] tracing: Fix filter string testing

On Thu, 17 Apr 2025 18:30:03 -0400 Steven Rostedt <rostedt@...dmis.org> wrote:

> From: Steven Rostedt <rostedt@...dmis.org>
> 
> The filter string testing uses strncpy_from_kernel/user_nofault() to
> retrieve the string to test the filter against. The if() statement was
> incorrect as it considered 0 as a fault, when it is only negative that it
> faulted.

changelog forgot to describe the userspace-visible effects of the bug?

> Cc: stable@...r.kernel.org

Which is more important when proposing this!