linux-kernel - RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH7PR16MB6196EF7F7A1862B48B66C5C5E5BC2@PH7PR16MB6196.namprd16.prod.outlook.com>
Date: Thu, 17 Apr 2025 04:59:03 +0000
From: Avri Altman <Avri.Altman@...disk.com>
To: DooHyun Hwang <dh0421.hwang@...sung.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "avri.altman@....com" <avri.altman@....com>,
	"bvanassche@....org" <bvanassche@....org>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "peter.wang@...iatek.com"
	<peter.wang@...iatek.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "quic_mnaresh@...cinc.com"
	<quic_mnaresh@...cinc.com>
CC: "grant.jung@...sung.com" <grant.jung@...sung.com>, "jt77.jang@...sung.com"
	<jt77.jang@...sung.com>, "junwoo80.lee@...sung.com"
	<junwoo80.lee@...sung.com>, "jangsub.yi@...sung.com"
	<jangsub.yi@...sung.com>, "sh043.lee@...sung.com" <sh043.lee@...sung.com>,
	"cw9316.lee@...sung.com" <cw9316.lee@...sung.com>, "sh8267.baek@...sung.com"
	<sh8267.baek@...sung.com>, "wkon.kim@...sung.com" <wkon.kim@...sung.com>
Subject: RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs cmd
 error

> There is no trace when a ufs uic cmd error occurs.
> So, add "UFS_CMD_ERR" enumeration to ufs_trace_str_t.
> 
> Signed-off-by: DooHyun Hwang <dh0421.hwang@...sung.com>
> ---
>  drivers/ufs/core/ufs_trace.h | 1 +
>  include/ufs/ufs.h            | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufs_trace.h b/drivers/ufs/core/ufs_trace.h index
> caa32e23ffa5..43830a092637 100644
> --- a/drivers/ufs/core/ufs_trace.h
> +++ b/drivers/ufs/core/ufs_trace.h
> @@ -41,6 +41,7 @@
>  #define UFS_CMD_TRACE_STRINGS                                  \
>         EM(UFS_CMD_SEND,        "send_req")                     \
>         EM(UFS_CMD_COMP,        "complete_rsp")                 \
> +       EM(UFS_CMD_ERR,         "req_complete_err")             \
>         EM(UFS_DEV_COMP,        "dev_complete")                 \
>         EM(UFS_QUERY_SEND,      "query_send")                   \
>         EM(UFS_QUERY_COMP,      "query_complete")               \
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
> c0c59a8f7256..7f2d418bdd86 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -631,7 +631,7 @@ struct ufs_dev_info {
>   * This enum is used in string mapping in ufs_trace.h.
>   */
>  enum ufs_trace_str_t {
> -       UFS_CMD_SEND, UFS_CMD_COMP, UFS_DEV_COMP,
> +       UFS_CMD_SEND, UFS_CMD_COMP, UFS_CMD_ERR, UFS_DEV_COMP,
>         UFS_QUERY_SEND, UFS_QUERY_COMP, UFS_QUERY_ERR,
>         UFS_TM_SEND, UFS_TM_COMP, UFS_TM_ERR  };
It seems strange to me that scsi & uic commands are designated by the same enum.
Has it been considered to add UFS_UIC_SEND, UFS_UIC_COMP, UFS_UIC_ERR to enum ufs_trace_str_t ?
Also looks like UFS_DEV_COMP is unused ?

Thanks,
Avri


> --
> 2.48.1