linux-kernel - Re: [PATCH net-next v4 00/14] yt6801: Add Motorcomm yt6801 PCIe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ad68dae-311f-4cdd-a6f8-0229f069ece3@motor-comm.com>
Date: Thu, 17 Apr 2025 14:06:05 +0800
From: Frank Sae <Frank.Sae@...or-comm.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Heiner Kallweit <hkallweit1@...il.com>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, netdev@...r.kernel.org,
 Masahiro Yamada <masahiroy@...nel.org>, Parthiban.Veerasooran@...rochip.com,
 linux-kernel@...r.kernel.org,
 "andrew+netdev @ lunn . ch" <andrew+netdev@...n.ch>, lee@...ger.us,
 horms@...nel.org, linux-doc@...r.kernel.org, corbet@....net,
 geert+renesas@...der.be, xiaogang.fan@...or-comm.com,
 fei.zhang@...or-comm.com, hua.sun@...or-comm.com
Subject: Re: [PATCH net-next v4 00/14] yt6801: Add Motorcomm yt6801 PCIe
 driver

On 2025/4/14 04:33, Andrew Lunn wrote:
> On Fri, Apr 11, 2025 at 05:50:55PM +0800, Frank Sae wrote:
>>
>>
>> On 2025/4/8 18:30, Russell King (Oracle) wrote:
>>> On Tue, Apr 08, 2025 at 05:28:21PM +0800, Frank Sae wrote:
>>>> This series includes adding Motorcomm YT6801 Gigabit ethernet driver
>>>>  and adding yt6801 ethernet driver entry in MAINTAINERS file.
>>>> YT6801 integrates a YT8531S phy.
>>>
>>> What is different between this and the Designware GMAC4 core supported
>>> by drivers/net/ethernet/stmicro/stmmac/ ?
>>>
>>
>> We support more features: NS, RSS, wpi, wol pattern and aspm control.
> 
> Details please as to why these preventing the stmmac driver from being
> used? Our default opinion will be that you will extend that stmmac
> driver. In order to change that, you need to give us deep technical
> arguments why it cannot be done.
> 

After internal discussion, we have decided to temporarily suspend upstream.
Thanks again!

>>> Looking at the register layout, it looks very similar. The layout of the
>>> MAC control register looks similar. The RX queue and PMT registers are
>>> at the same relative offset. The MDIO registers as well.
>>>
>>> Can you re-use the stmmac driver?
>>>
>>
>> I can not re-use the stmmac driver, because pcie and ephy can not work well on
>> the stmmac driver.
> 
> Please could you explain that in detail. What exactly does not work?
> What is stmmac_pci.c about if not PCI?
> 
> 	Andrew