linux-kernel - Re: [PATCH 03/13] dt-bindings: mmc: vt8500-sdmmc: Convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABjd4YyTKquLcYC+DVg_koi3p7AhqwBNiazCiC713DQKjCaBSA@mail.gmail.com>
Date: Thu, 17 Apr 2025 10:25:51 +0400
From: Alexey Charkov <alchark@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Andi Shyti <andi.shyti@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, 
	netdev@...r.kernel.org, linux-pwm@...r.kernel.org
Subject: Re: [PATCH 03/13] dt-bindings: mmc: vt8500-sdmmc: Convert to YAML

On Thu, Apr 17, 2025 at 12:14 AM Rob Herring <robh@...nel.org> wrote:
>
> On Wed, Apr 16, 2025 at 12:21:28PM +0400, Alexey Charkov wrote:
> > Rewrite the textual description for the WonderMedia SDMMC controller
> > as YAML schema, and switch the filename to follow the compatible
> > string.
> >
> > Signed-off-by: Alexey Charkov <alchark@...il.com>
> > ---
> >  .../devicetree/bindings/mmc/vt8500-sdmmc.txt       | 23 --------
> >  .../devicetree/bindings/mmc/wm,wm8505-sdhc.yaml    | 61 ++++++++++++++++++++++
> >  MAINTAINERS                                        |  1 +
> >  3 files changed, 62 insertions(+), 23 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/vt8500-sdmmc.txt b/Documentation/devicetree/bindings/mmc/vt8500-sdmmc.txt
> > deleted file mode 100644
> > index d7fb6abb3eb8c87e698ca4f30270c949878f3cbf..0000000000000000000000000000000000000000
> > --- a/Documentation/devicetree/bindings/mmc/vt8500-sdmmc.txt
> > +++ /dev/null
> > @@ -1,23 +0,0 @@
> > -* Wondermedia WM8505/WM8650 SD/MMC Host Controller
> > -
> > -This file documents differences between the core properties described
> > -by mmc.txt and the properties used by the wmt-sdmmc driver.
> > -
> > -Required properties:
> > -- compatible: Should be "wm,wm8505-sdhc".
> > -- interrupts: Two interrupts are required - regular irq and dma irq.
> > -
> > -Optional properties:
> > -- sdon-inverted: SD_ON bit is inverted on the controller
> > -
> > -Examples:
> > -
> > -sdhc@...0a000 {
> > -     compatible = "wm,wm8505-sdhc";
> > -     reg = <0xd800a000 0x1000>;
> > -     interrupts = <20 21>;
> > -     clocks = <&sdhc>;
> > -     bus-width = <4>;
> > -     sdon-inverted;
> > -};
> > -
> > diff --git a/Documentation/devicetree/bindings/mmc/wm,wm8505-sdhc.yaml b/Documentation/devicetree/bindings/mmc/wm,wm8505-sdhc.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..a7d962bc13c7ff70b50448201b0416efc7f787af
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/wm,wm8505-sdhc.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mmc/wm,wm8505-sdhc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: WonderMedia SOC SoC SDHCI Controller
> > +
> > +maintainers:
> > +  - Alexey Charkov <alchark@...il.com>
> > +
> > +allOf:
> > +  - $ref: mmc-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - const: wm,wm8505-sdhc
> > +      - items:
> > +          - const: wm,wm8650-sdhc
> > +          - const: wm,wm8505-sdhc
> > +      - items:
> > +          - const: wm,wm8750-sdhc
> > +          - const: wm,wm8505-sdhc
> > +      - items:
> > +          - const: wm,wm8850-sdhc
> > +          - const: wm,wm8505-sdhc
>
> Combine the last 3 entries into 1 using 'enum' for the 1st compatible.

Fair enough, will do.

> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    items:
> > +      - description: SDMMC controller interrupt
> > +      - description: SDMMC controller DMA interrupt
> > +
> > +  sdon-inverted:
> > +    type: boolean
> > +    description: SD_ON bit is inverted on the controller
>
> This implies I know what the non-inverted state is. If you know, please
> state that here.

This is a tricky one. The only answer I have is "it's inverted in
later versions vs. the first version I saw in the wild, and I'm not
sure if it's board related or IP version related - nor if the original
was active low or high". No docs, no schematics, no vendor left around
to chase for answers.

Will dig around some more and update the description if I succeed in
uncovering any further clues :)

Best regards,
Alexey