linux-kernel - Re: [PATCH v3] media: davinci: vpif: Fix memory leak in probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aACoQJbpN5v_UGrj@hovoldconsulting.com>
Date: Thu, 17 Apr 2025 09:05:36 +0200
From: Johan Hovold <johan@...nel.org>
To: Dmitry Nikiforov <Dm1tryNk@...dex.ru>
Cc: "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v3] media: davinci: vpif: Fix memory leak in probe error
 path

On Wed, Apr 16, 2025 at 11:51:19PM +0300, Dmitry Nikiforov wrote:
> If an error occurs during the initialization of `pdev_display`,
> the allocated platform device `pdev_capture` is not released properly,
> leading to a memory leak.
> 
> Adjust error path handling to fix the leak.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 43acb728bbc4 ("media: davinci: vpif: fix use-after-free on driver unbind")
> Signed-off-by: Dmitry Nikiforov <Dm1tryNk@...dex.ru>
> ---
> v2: also fix of_graph_get_endpoint_by_regs() error path.
> v3: Rework incorrect error handling added in v2.
> Also fix missing platform_device_del() in another error path (Johan Hovold).

Thanks for the update. Looks good:

Reviewed-by: Johan Hovold <johan@...nel.org>