linux-kernel - Re: [PATCH v3 4/8] dt-bindings: phy: mtk-xs-phy: support type switch by pericfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caf3da77-f35d-4a39-9102-9592d722d900@kernel.org>
Date: Thu, 17 Apr 2025 09:59:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Frank Wunderlich (linux)" <linux@...web.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 Chunfeng Yun <chunfeng.yun@...iatek.com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Frank Wunderlich <frank-w@...lic-files.de>, Rafał Miłecki
 <rafal@...ecki.pl>, Daniel Golle <daniel@...rotopia.org>,
 Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v3 4/8] dt-bindings: phy: mtk-xs-phy: support type switch
 by pericfg

On 17/04/2025 09:52, Frank Wunderlich (linux) wrote:
>>>
>>> +      mediatek,syscon-type:
>>> +        $ref: /schemas/types.yaml#/definitions/phandle-array
>>> +        maxItems: 1
>>> +        description:
>>> +          A phandle to syscon used to access the register of type 
>>> switch,
>>> +          the field should always be 3 cells long.
>>> +        items:
>>> +          items:
>>
>> Missing -, because you have one phandle.
> 
> ok, then i need to drop MaxItems and indent 2 spaces more, but no 
> problem

I missed that maxItems - should not be placed above description, but
immediately around items.

> 
>>> +            - description:
>>> +                The first cell represents a phandle to syscon
>>
>> Don't repeat constraints in free form text. "Foo bar system controller"
>> or "Phandle to foo bar system controller"
> 
> i would write only "phandle to system controller". on mt7988 it is the 
> topmisc syscon, but maybe on
> other SoC it is different name.

This must be specific to what sort of system controller you point. You
are not interested in phandle to any system controller.

> 
>>> +            - description:
>>> +                The second cell represents the register offset
>>
>> "Baz register offset"
> 
> same here, only "register offset".

Also not. You need specific register, not any register.


Best regards,
Krzysztof