linux-kernel - Re: [PATCH RESEND] media: adv7511-v4l2: use constants for BT.2020 colorimetry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174487700624.494853.2007394433912766175@ping.linuxembedded.co.uk>
Date: Thu, 17 Apr 2025 09:03:26 +0100
From: Kieran Bingham <kieran.bingham@...asonboard.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, Hans Verkuil <hverkuil@...all.nl>, Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Subject: Re: [PATCH RESEND] media: adv7511-v4l2: use constants for BT.2020 colorimetry

Quoting Dmitry Baryshkov (2025-04-16 23:46:01)
> Replace numeric values with constants from hdmi.h.
> 

[x] adv7511-v4l2.c includes hdmi.h 
[x] hdmi.h defines the same values (through an enum)

Checks out for me.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>  drivers/media/i2c/adv7511-v4l2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v4l2.c
> index f95a99d85360aa782279a127eee37132f9ad08fb..853c7806de928da2129f603e7cb673440a1fcfac 100644
> --- a/drivers/media/i2c/adv7511-v4l2.c
> +++ b/drivers/media/i2c/adv7511-v4l2.c
> @@ -1370,9 +1370,9 @@ static int adv7511_set_fmt(struct v4l2_subdev *sd,
>         case V4L2_COLORSPACE_BT2020:
>                 c = HDMI_COLORIMETRY_EXTENDED;
>                 if (y && format->format.ycbcr_enc == V4L2_YCBCR_ENC_BT2020_CONST_LUM)
> -                       ec = 5; /* Not yet available in hdmi.h */
> +                       ec = HDMI_EXTENDED_COLORIMETRY_BT2020_CONST_LUM;
>                 else
> -                       ec = 6; /* Not yet available in hdmi.h */
> +                       ec = HDMI_EXTENDED_COLORIMETRY_BT2020;
>                 break;
>         default:
>                 break;
> 
> ---
> base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c
> change-id: 20250408-adv7511-ec-const-b46796340439
> 
> Best regards,
> -- 
> Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>