linux-kernel - Re: [PATCH] netfs: Mark _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250417-manchmal-verbal-7f84877a2c63@brauner>
Date: Thu, 17 Apr 2025 10:13:57 +0200
From: Christian Brauner <brauner@...nel.org>
To: David Howells <dhowells@...hat.com>,
	Kees Cook <kees@...nel.org>
Cc: Christian Brauner <brauner@...nel.org>,
	Paulo Alcantara <pc@...guebit.com>,
	netfs@...ts.linux.dev,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] netfs: Mark __nonstring lookup tables

On Wed, 16 Apr 2025 15:16:55 -0700, Kees Cook wrote:
> GCC 15's new -Wunterminated-string-initialization notices that the
> character lookup tables "fscache_cache_states" and "fscache_cookie_states"
> (which are not used as a C-String) need to be marked as "nonstring":
> 
> fs/netfs/fscache_cache.c:375:67: warning: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (6 chars into 5 available) [-Wunterminated-string-initialization]
>   375 | static const char fscache_cache_states[NR__FSCACHE_CACHE_STATE] = "-PAEW";
>       |                                                                   ^~~~~~~
> fs/netfs/fscache_cookie.c:32:69: warning: initializer-string for array of 'char' truncates NUL terminator but destination lacks 'nonstring' attribute (11 chars into 10 available) [-Wunterminated-string-initialization]
>    32 | static const char fscache_cookie_states[FSCACHE_COOKIE_STATE__NR] = "-LCAIFUWRD";
>       |                                                                     ^~~~~~~~~~~~
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] netfs: Mark __nonstring lookup tables
      https://git.kernel.org/vfs/vfs/c/58db1c3cd0ce