linux-kernel - Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAC6qM1LnNZnHrCI@nchen-desktop>
Date: Thu, 17 Apr 2025 16:24:08 +0800
From: Peter Chen <peter.chen@...tech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: soc@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, catalin.marinas@....com, will@...nel.org,
	arnd@...db.de, jassisinghbrar@...il.com,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
	maz@...nel.org, kajetan.puchalski@....com,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Fugang Duan <fugang.duan@...tech.com>,
	Guomin Chen <Guomin.Chen@...tech.com>,
	Gary Yang <gary.yang@...tech.com>
Subject: Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts
 support

> >>
> >> On 15/04/2025 09:27, Peter Chen wrote:
> >>> +
> >>> +             mbox_ap2pm: mailbox@...0080 {
> >>> +                     compatible = "cix,sky1-mbox";
> >>> +                     reg = <0x0 0x06590080 0x0 0xff80>;
> >>> +                     interrupts = <GIC_SPI 363 IRQ_TYPE_LEVEL_HIGH 0>;
> >>> +                     #mbox-cells = <1>;
> >>> +                     cix,mbox-dir = "tx";
> >>> +             };
> >>> +
> >>> +             pm2ap_scmi_mem: pm2ap-shmem@...0000 {
> >>> +                     compatible = "arm,scmi-shmem";
> >>> +                     #address-cells = <2>;
> >>> +                     #size-cells = <2>;
> >>> +                     reg-io-width = <4>;
> >>> +                     reg = <0x0 0x065a0000 0x0 0x80>;
> >>
> >> Messed order of properties. Keep it consistent (see DTS conding style).
> >> Other nodes also have oddly placed reg.
> >
> > Thanks for your reviewing, Krzysztof.
> >
> > All the nodes mailbox and shmem (in mailbox) are on the same bus, so
> > I keep it by unit address in ascending order like DTS coding sytle
> > says. I think below rules are two options, isn't it?
> 
> You speak about nodes I wrote about properties. I don't understand how
> your question is relevant to my comment.
> 
> 

Sorry, we will update the sequence of properties in node.

-- 

Best regards,
Peter