linux-kernel - Re: [PATCH v1] rtla: Set distinctive exit value for failed tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP4=nvQnV-hqNXhAJq0EYggRFq_=K3PRWJ15qutoQhLzyH8hGg@mail.gmail.com>
Date: Thu, 17 Apr 2025 11:02:19 +0200
From: Tomas Glozar <tglozar@...hat.com>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, John Kacur <jkacur@...hat.com>, 
	"Luis Claudio R. Goncalves" <lgoncalv@...hat.com>, Eder Zulian <ezulian@...hat.com>, 
	Dan Carpenter <dan.carpenter@...aro.org>, Jan Stancek <jstancek@...hat.com>, 
	linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] rtla: Set distinctive exit value for failed tests

čt 17. 4. 2025 v 10:48 odesílatel Costa Shulyupin
<costa.shul@...hat.com> napsal:
> Although it is technically possible to rely on a failed value zero, I
> suppose it is very unexpected. I expect current users only grep the
> output of rtla.
> I think adding a new command line argument is overcomplicated. Adding
> a new command-line argument for this seems unnecessarily complex, and
> I'm not aware of any Linux/POSIX tools that offer such an option.
>

Alright, you convinced me, I unnecessarily exaggerated the impact of
the exit value change. It's common for Unix tools like grep to return
2 on "unclean" result ("no match found" in the case of grep,
"measurement aborted prematurely because of threshold violated" in the
case of rtla). If users are expecting 0, they can be adjusted to
accommodate for both the old and new behavior without issue.

I'll reply with a review on the main thread later.

Tomas