linux-kernel - Re: [PATCH v2] staging: gpib: include: fixes multiline comments style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025041748-opposing-macaroni-8a89@gregkh>
Date: Thu, 17 Apr 2025 11:23:50 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Paul Retourné <paul.retourne@...nge.fr>
Cc: dpenkler@...il.com, dan.carpenter@...aro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: gpib: include: fixes multiline comments style

On Wed, Apr 16, 2025 at 02:04:09PM -0700, Paul Retourné wrote:
> Fixes the style of multiline comments to comply with the linux kernel
> coding style.
> 
> Signed-off-by: Paul Retourné <paul.retourne@...nge.fr>

I've applied this (took some manual intervention on my side), but:

> @@ -37,11 +38,13 @@ struct gpib_board_config {
>  	unsigned int ibirq;
>  	/* dma channel to use for non-pnp cards (set by core, driver should make local copy) */
>  	unsigned int ibdma;
> -	/* pci bus of card, useful for distinguishing multiple identical pci cards
> +	/*
> +	 * pci bus of card, useful for distinguishing multiple identical pci cards
>  	 * (negative means don't care)
>  	 */
>  	int pci_bus;

For these, and the other definitions in this file, can you move the
comments to use the proper kerneldoc format for the structure, so that
the tools can properly document the structures in here?  Having comments
above the variables really is not the best way to do this.

thanks,

greg k-h