linux-kernel - Re: [PATCH] mm/vmscan: Modify the assignment logic of the scan and total

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c655ec08-1adc-4c50-878a-bdc6445875b7@arm.com>
Date: Thu, 17 Apr 2025 15:05:14 +0530
From: Dev Jain <dev.jain@....com>
To: Hao Ge <hao.ge@...ux.dev>, Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Hao Ge <gehao@...inos.cn>
Subject: Re: [PATCH] mm/vmscan: Modify the assignment logic of the scan and
 total_scan variables



On 17/04/25 2:54 pm, Hao Ge wrote:
> From: Hao Ge <gehao@...inos.cn>
> 
> The scan and total_scan variables can be initialized to 0
> when they are defined, replacing the separate assignment statements.
> 
> Signed-off-by: Hao Ge <gehao@...inos.cn>

Acked-by: Dev Jain <dev.jain@....com>

> ---
>   mm/vmscan.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b620d74b0f66..bf360ac4f1cf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1725,13 +1725,11 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan,
>   	unsigned long nr_taken = 0;
>   	unsigned long nr_zone_taken[MAX_NR_ZONES] = { 0 };
>   	unsigned long nr_skipped[MAX_NR_ZONES] = { 0, };
> -	unsigned long skipped = 0;
> -	unsigned long scan, total_scan, nr_pages;
> +	unsigned long skipped = 0, total_scan = 0, scan = 0;
> +	unsigned long nr_pages;
>   	unsigned long max_nr_skipped = 0;
>   	LIST_HEAD(folios_skipped);
>   
> -	total_scan = 0;
> -	scan = 0;
>   	while (scan < nr_to_scan && !list_empty(src)) {
>   		struct list_head *move_to = src;
>   		struct folio *folio;