linux-kernel - Re: [PATCH v0] net: ethtool: Only set supplied eee ethtool settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19ffa505b6c4341e6c66370fb76f6447b820aacd.camel@alliedtelesis.co.nz>
Date: Thu, 17 Apr 2025 00:36:43 +0000
From: Rutger van Kruiningen <Rutger.vanKruiningen@...iedtelesis.co.nz>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "horms@...nel.org" <horms@...nel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "kuba@...nel.org" <kuba@...nel.org>
Subject: Re: [PATCH v0] net: ethtool: Only set supplied eee ethtool settings

On Thu, 2025-04-17 at 00:36 +0200, Andrew Lunn wrote:
> On Thu, Apr 17, 2025 at 10:12:30AM +1200, Rutger van Kruiningen
> wrote:
> > Originally all ethtool eee setting updates were attempted even if
> > the
> > settings were not supplied, causing a null pointer crash.
> > 
> > Add check for each eee setting and only update if it exists.
> 
> I see what you mean, but i'm somewhat surprised we have not seen this
> crash. Do you have a simple reproducer? I just did
> 
> ethtool --debug 255 --set-eee eth0 eee on
> 
> and it did not crash, despite:
> 
> sending genetlink packet (44 bytes):
>     msg length 44 ethool ETHTOOL_MSG_EEE_SET
>     ETHTOOL_MSG_EEE_SET
>         ETHTOOL_A_EEE_HEADER
>             ETHTOOL_A_HEADER_DEV_NAME = "eth0"
>         ETHTOOL_A_EEE_ENABLED = on
> 
> So it only provided ETHTOOL_A_EEE_ENABLED and none of the others.
> 
>         Andrew
Sorry it seems that there actually isn't a problem here. I thought the
bug I had was related to this but it must have been for something else
and was fixed at the same time of adding this code.

You can disreguard this patch.

Thanks, Rutger.