linux-kernel - Re: [PATCH] powerpc: do not build ppc_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250417222625.50a6684e@canb.auug.org.au>
Date: Thu, 17 Apr 2025 22:26:25 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: maddy@...ux.ibm.com, linux-kernel@...r.kernel.org, Michael Ellerman
 <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Naveen N Rao <naveen@...nel.org>,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc: do not build ppc_save_regs.o always

Hi Jiri,

On Thu, 17 Apr 2025 12:53:05 +0200 "Jiri Slaby (SUSE)" <jirislaby@...nel.org> wrote:
>
> The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the
> conditions to enable the build of ppc_save_regs.o. But it failed to do
> so, in fact. The commit omitted to add a dollar sign.
> 
> Therefore, ppc_save_regs.o is built always these days (as
> "(CONFIG_PPC_BOOK3S)" is never an empty string).
> 
> Fix this by adding the missing dollar sign.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Fixes: fc2a5a6161a2 ("powerpc/64s: ppc_save_regs is now needed for all 64s builds")
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Naveen N Rao <naveen@...nel.org>
> Cc: linuxppc-dev@...ts.ozlabs.org

Thanks for that.

Only 7.5 years later :-)  This shows why I should not have been fixing
problems in linux-next, I should have only ever complained about them,
like I do now :-)

Acked-by: Stephen Rothwell <sfr@...b.auug.org.au>

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped