linux-kernel - Re: [PATCH v3 03/32] selftests: harness: Ignore unused variant argument warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <746df70d-b8de-465a-86a5-44a23486af40@collabora.com>
Date: Fri, 18 Apr 2025 21:57:26 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Shuah Khan <shuah@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>,
 Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>, Kees Cook <kees@...nel.org>
Cc: Andy Lutomirski <luto@...capital.net>, Will Drewry <wad@...omium.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 03/32] selftests: harness: Ignore unused variant
 argument warning

On 4/11/25 2:00 PM, Thomas Weißschuh wrote:
> For tests without fixtures the variant argument is unused.
> This is intentional, prevent to compiler from complaining.
> 
> Example warning:
> 
>     harness-selftest.c: In function 'wrapper_standalone_pass':
>     ../kselftest_harness.h:181:52: error: unused parameter 'variant' [-Werror=unused-parameter]
>       181 |                 struct __fixture_variant_metadata *variant) \
>           |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
>     ../kselftest_harness.h:156:25: note: in expansion of macro '__TEST_IMPL'
>       156 | #define TEST(test_name) __TEST_IMPL(test_name, -1)
>           |                         ^~~~~~~~~~~
>     harness-selftest.c:15:1: note: in expansion of macro 'TEST'
>        15 | TEST(standalone_pass) {
>           | ^~~~
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/kselftest_harness.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index bac4327775ea65dbe977e9b22ee548bedcbd33ff..2b350ed60b2bf1cbede8e3a9b4ac5fe716900144 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -174,7 +174,7 @@
>  	static void test_name(struct __test_metadata *_metadata); \
>  	static inline void wrapper_##test_name( \
>  		struct __test_metadata *_metadata, \
> -		struct __fixture_variant_metadata *variant) \
> +		struct __fixture_variant_metadata __attribute__((unused)) *variant) \
>  	{ \
>  		_metadata->setup_completed = true; \
>  		if (setjmp(_metadata->env) == 0) \
> 


-- 
Regards,
Usama