linux-kernel - Re: [PATCH AUTOSEL 6.1 6/9] ASoC: fsl_audmix: register card device depends on 'dais' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAKE4kb6gImSpK5L@duo.ucw.cz>
Date: Fri, 18 Apr 2025 18:59:14 +0200
From: Pavel Machek <pavel@...x.de>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Shengjiu Wang <shengjiu.wang@....com>,
	Mark Brown <broonie@...nel.org>, shengjiu.wang@...il.com,
	Xiubo.Lee@...il.com, lgirdwood@...il.com, perex@...ex.cz,
	tiwai@...e.com, linux-sound@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH AUTOSEL 6.1 6/9] ASoC: fsl_audmix: register card device
 depends on 'dais' property

Hi!

> [ Upstream commit 294a60e5e9830045c161181286d44ce669f88833 ]
> 
> In order to make the audmix device linked by audio graph card, make
> 'dais' property to be optional.
> 
> If 'dais' property exists, then register the imx-audmix card driver.
> otherwise, it should be linked by audio graph card.

This is part of series, AFAICT; should we have it in -stable?

Best regards,
									Pavel

> +++ b/sound/soc/fsl/fsl_audmix.c
> @@ -492,11 +492,17 @@ static int fsl_audmix_probe(struct platform_device *pdev)
>  		goto err_disable_pm;
>  	}
>  
> -	priv->pdev = platform_device_register_data(dev, "imx-audmix", 0, NULL, 0);
> -	if (IS_ERR(priv->pdev)) {
> -		ret = PTR_ERR(priv->pdev);
> -		dev_err(dev, "failed to register platform: %d\n", ret);
> -		goto err_disable_pm;
> +	/*
> +	 * If dais property exist, then register the imx-audmix card driver.
> +	 * otherwise, it should be linked by audio graph card.
> +	 */
> +	if (of_find_property(pdev->dev.of_node, "dais", NULL)) {
> +		priv->pdev = platform_device_register_data(dev, "imx-audmix", 0, NULL, 0);
> +		if (IS_ERR(priv->pdev)) {
> +			ret = PTR_ERR(priv->pdev);
> +			dev_err(dev, "failed to register platform: %d\n", ret);
> +			goto err_disable_pm;
> +		}
>  	}
>  
>  	return 0;

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)