linux-kernel - Re: [PATCH net-next] rxrpc: rxgk: Set error code in rxgk_yfs_decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250418170044.GB2676982@horms.kernel.org>
Date: Fri, 18 Apr 2025 18:00:44 +0100
From: Simon Horman <horms@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: David Howells <dhowells@...hat.com>,
	Marc Dionne <marc.dionne@...istor.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-afs@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] rxrpc: rxgk: Set error code in
 rxgk_yfs_decode_ticket()

On Wed, Apr 16, 2025 at 02:09:51PM +0300, Dan Carpenter wrote:
> Propagate the error code if key_alloc() fails.  Don't return
> success.
> 
> Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Simon Horman <horms@...nel.org>

...

> diff --git a/net/rxrpc/rxgk_app.c b/net/rxrpc/rxgk_app.c
> index 6206a84395b8..b94b77a1c317 100644
> --- a/net/rxrpc/rxgk_app.c
> +++ b/net/rxrpc/rxgk_app.c
> @@ -141,6 +141,7 @@ int rxgk_yfs_decode_ticket(struct rxrpc_connection *conn, struct sk_buff *skb,
>  			KEY_ALLOC_NOT_IN_QUOTA, NULL);
>  	if (IS_ERR(key)) {
>  		_leave(" = -ENOMEM [alloc %ld]", PTR_ERR(key));

Not a bug, but it doesn't seem ideal that _leave(), which logs a debug
message, is called here and with a more general format in the error label.

> +		ret = PTR_ERR(key);
>  		goto error;
>  	}
>  
> -- 
> 2.47.2
>