linux-kernel - Re: [PATCH v2] lib/test_kmod: do not hardcode/depend on any filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAKRygQdkdlyZ_ai@bombadil.infradead.org>
Date: Fri, 18 Apr 2025 10:54:18 -0700
From: Luis Chamberlain <mcgrof@...nel.org>
To: "Herton R. Krzesinski" <herton@...hat.com>
Cc: linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, petr.pavlu@...e.com,
	samitolvanen@...gle.com, da.gomez@...sung.com, nathan@...nel.org
Subject: Re: [PATCH v2] lib/test_kmod: do not hardcode/depend on any
 filesystem

On Fri, Apr 18, 2025 at 01:50:47PM -0300, Herton R. Krzesinski wrote:
> Right now test_kmod has hardcoded dependencies on btrfs/xfs. That
> is not optimal since you end up needing to select/build them, but it
> is not really required since other fs could be selected for the testing.
> Also, we can't change the default/driver module used for testing on
> initialization.
> 
> Thus make it more generic: introduce two module parameters (start_driver
> and start_test_fs), which allow to select which modules/fs to use for
> the testing on test_kmod initialization. Then it's up to the user to
> select which modules/fs to use for testing based on his config. However,
> keep test_module as required default.
> 
> This way, config/modules becomes selectable as when the testing is done
> from selftests (userspace).
> 
> While at it, also change trigger_config_run_type, since at module
> initialization we already set the defaults at __kmod_config_init and
> should not need to do it again in test_kmod_init(), thus we can
> avoid to again set test_driver/test_fs.
> 
> v2: also update tools/testing/selftests/kmod/config with the removed
> dependencies.
> 
> Signed-off-by: Herton R. Krzesinski <herton@...hat.com>

Reviewed-by: Luis Chambelrain <mcgrof@...nel.org>

  Luis