linux-kernel - Re: [PATCH v8 23/24] nvme-pci: convert to blk_rq_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bdbb334-5849-4099-9284-ffe293aac144@oracle.com>
Date: Fri, 18 Apr 2025 23:59:09 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Leon Romanovsky <leon@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        Keith Busch <kbusch@...nel.org>
Cc: Jake Edge <jake@....net>, Jonathan Corbet <corbet@....net>,
        Jason Gunthorpe <jgg@...pe.ca>, Zhu Yanjun <zyjzyj2000@...il.com>,
        Robin Murphy <robin.murphy@....com>, Joerg Roedel <joro@...tes.org>,
        Will Deacon <will@...nel.org>, Sagi Grimberg <sagi@...mberg.me>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Yishai Hadas <yishaih@...dia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-rdma@...r.kernel.org, iommu@...ts.linux.dev,
        linux-nvme@...ts.infradead.org, linux-pci@...r.kernel.org,
        kvm@...r.kernel.org, linux-mm@...ck.org,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Chuck Lever <chuck.lever@...cle.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Dan Williams
 <dan.j.williams@...el.com>,
        Kanchan Joshi <joshi.k@...sung.com>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH v8 23/24] nvme-pci: convert to blk_rq_dma_map



On 18-04-2025 12:17, Leon Romanovsky wrote:
> +	prp_list = iod->descriptors[desc];
> +	do {
> +		/*
> +		 * We are in this mode as IOVA path wasn't taken and DMA length
> +		 * is morethan two sectors. In such case, mapping was perfoormed
> +		 * per-NVME_CTRL_PAGE_SIZE, so unmap accordingly.
> +		 */

typo perfoormed -> performed , morethan  -> more than

> +		dma_unmap_page(dev->dev, dma_addr, dma_len, dir);
> +		if (i == NVME_CTRL_PAGE_SIZE >> 3) {
> +			prp_list = iod->descriptors[++desc];
> +			i = 0;
> +		}


Thanks,
Alok