linux-kernel - Re: [PATCH] iio: amplifiers: ada4250: use DMA-safe memory for regmap_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed5c4b46-0b3f-4278-ba8e-6f6977f18429@baylibre.com>
Date: Fri, 18 Apr 2025 14:09:04 -0500
From: David Lechner <dlechner@...libre.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: amplifiers: ada4250: use DMA-safe memory for
 regmap_bulk_read()

On 4/18/25 1:58 PM, Andy Shevchenko wrote:
> 
> 
> пʼятниця, 18 квітня 2025 р. David Lechner <dlechner@...libre.com <mailto:dlechner@...libre.com>> пише:
> 
>     Use DMA-safe memory instead of stack-allocated memory for the call to
>     regmap_bulk_read() in the ada4250_init() function as this could be used
>     directly by a SPI controller.
> 
> 
> Sorry, but can you elaborate more on this? If driver doesn’t override the callbacks the regmap SPI uses spi_write_then_read() which is supposed to be dma safe. 
>  
> 

Ah, I didn't dig that far down. Will send a new patch that just cleans up the
unnecessary alignment and unaligned call.

(Also can't believe you sent HTML mail!)