linux-kernel - Re: [PATCH v5 8/8] iommu: Remove iommu_dev_enable/disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAK010Tb+1AYp8F1@Asurada-Nvidia>
Date: Fri, 18 Apr 2025 13:23:51 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>
CC: Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, "Robin
 Murphy" <robin.murphy@....com>, Jason Gunthorpe <jgg@...pe.ca>, Kevin Tian
	<kevin.tian@...el.com>, Dave Jiang <dave.jiang@...el.com>, Vinod Koul
	<vkoul@...nel.org>, Fenghua Yu <fenghuay@...dia.com>, Zhangfei Gao
	<zhangfei.gao@...aro.org>, Zhou Wang <wangzhou1@...ilicon.com>,
	<iommu@...ts.linux.dev>, <linux-kernel@...r.kernel.org>, Jason Gunthorpe
	<jgg@...dia.com>
Subject: Re: [PATCH v5 8/8] iommu: Remove iommu_dev_enable/disable_feature()

On Fri, Apr 18, 2025 at 04:01:30PM +0800, Lu Baolu wrote:
> No external drivers use these interfaces anymore. Furthermore, no existing
> iommu drivers implement anything in the callbacks. Remove them to avoid
> dead code.
> 
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
> Tested-by: Zhangfei Gao <zhangfei.gao@...aro.org>

Reviewed-by: Nicolin Chen <nicolinc@...dia.com>

With the following:

> @@ -657,9 +647,6 @@ struct iommu_ops {
>  	bool (*is_attach_deferred)(struct device *dev);
>  
>  	/* Per device IOMMU features */
> -	int (*dev_enable_feat)(struct device *dev, enum iommu_dev_features f);
> -	int (*dev_disable_feat)(struct device *dev, enum iommu_dev_features f);

They should be dropped in the kdoc too.