linux-kernel - Re: [PATCH v2 0/2] rename var for slice refill event and add helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01d5eb3b-f312-46a1-b8d2-22be8bcfa5f9@igalia.com>
Date: Fri, 18 Apr 2025 12:55:51 +0900
From: Changwoo Min <changwoo@...lia.com>
To: Honglei Wang <jameshongleiwang@....com>, tj@...nel.org,
 void@...ifault.com, arighi@...dia.com
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
 vincent.guittot@...aro.org, dietmar.eggemann@....com, rostedt@...dmis.org,
 bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com,
 joshdon@...gle.com, brho@...gle.com, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [PATCH v2 0/2] rename var for slice refill event and add helper

Hi Honglei,

Thanks for the contribution. The change looks good to me.

Acked-by: Changwoo Min <changwoo@...lia.com>

On 4/18/25 12:26, Honglei Wang wrote:
> SCX_EV_ENQ_SLICE_DFL gives the impression that the event only occurs
> when the tasks were enqueued, which seems not accurate. So rename the
> variable to SCX_EV_REFILL_SLICE_DFL.
> 
> The slice refilling with default slice always come with event
> statistics together, add a helper routine to make it cleaner.
> 
> Changes in v2:
> Refine the comments base on Andrea's suggestion.
> 
> Honglei Wang (2):
>    sched_ext: change the variable name for slice refill event
>    sched_ext: add helper for refill task with default slice
> 
>   kernel/sched/ext.c             | 36 +++++++++++++++++-----------------
>   tools/sched_ext/scx_qmap.bpf.c |  4 ++--
>   2 files changed, 20 insertions(+), 20 deletions(-)
>