linux-kernel - [PATCH v2] wifi: iwlwifi: pcie: Fix match condition in iwl_pci_find_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250418-probe-fix-v2-1-ec1ef2d8a534@gmail.com>
Date: Fri, 18 Apr 2025 03:29:37 -0300
From: Kurt Borja <kuurtb@...il.com>
To: Miri Korenblit <miriam.rachel.korenblit@...el.com>, 
 Johannes Berg <johannes.berg@...el.com>, 
 Emmanuel Grumbach <emmanuel.grumbach@...el.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Kurt Borja <kuurtb@...il.com>
Subject: [PATCH v2] wifi: iwlwifi: pcie: Fix match condition in
 iwl_pci_find_dev_info()

Fix the following regression:

iwlwifi: No config found for PCI dev 2725/1674, rev=0x420, rfid=0x10d000
iwlwifi 0000:3b:00.0: probe with driver iwlwifi failed with error -22

Which happens due to an extra `!` when matching `dev_info` while
probing.

Fixes: 75a3313f52b7 ("wifi: iwlwifi: make no_160 more generic")
Signed-off-by: Kurt Borja <kuurtb@...il.com>
---
Hi all,

After testing Linux v6.15-rc1 I found that my wifi card was failing to
probe. This is a major regression which leaves me without wifi and is
still present in Linux v6.15-rc2.

Bisecting led to:

first bad commit: [75a3313f52b7] wifi: iwlwifi: make no_160 more generic

in which I found this this `!` typo.

I already sent a fix for this (v1), but it probably ended up in spam due
to a bad DKIM signature.

This patch is based on the for-next branch of the wireless/wireless.git
tree.
---
Changes since v1:
  - Heavily reword commit message to be more clear
  - Link: https://lore.kernel.org/r/20250329-wifi-fix-v1-1-d6360e78f091@gmail.com/
---
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 93446c37400814e2c27ddd2fe93136862fcf4eee..555323341e7d6d7b94e29b4b4530b056bf6433ec 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -1449,7 +1449,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
 		 * !bw_limit to have a match.
 		 */
 		if (dev_info->bw_limit != IWL_CFG_BW_ANY &&
-		    (dev_info->bw_limit == IWL_CFG_BW_NO_LIM) == !!bw_limit)
+		    (dev_info->bw_limit == IWL_CFG_BW_NO_LIM) == !bw_limit)
 			continue;
 
 		if (dev_info->cores != (u8)IWL_CFG_ANY &&

---
base-commit: 0937cb5f345c79d702b4d0d744e2a2529b551cb2
change-id: 20250418-probe-fix-f280c81c2732

Best regards,
-- 
 ~ Kurt