linux-kernel - RE: [PATCH] ufs: core: Add HID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR16MB6196FDEFFF1041EAD0668AC7E5BF2@PH7PR16MB6196.namprd16.prod.outlook.com>
Date: Fri, 18 Apr 2025 08:05:46 +0000
From: Avri Altman <Avri.Altman@...disk.com>
To: Huan Tang <tanghuan@...o.com>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "avri.altman@....com" <avri.altman@....com>,
	"bvanassche@....org" <bvanassche@....org>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>,
	"keosung.park@...sung.com" <keosung.park@...sung.com>,
	"quic_ziqichen@...cinc.com" <quic_ziqichen@...cinc.com>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>, "gwendal@...omium.org"
	<gwendal@...omium.org>, "peter.wang@...iatek.com" <peter.wang@...iatek.com>,
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
	"quic_cang@...cinc.com" <quic_cang@...cinc.com>, "quic_nguyenb@...cinc.com"
	<quic_nguyenb@...cinc.com>, "ebiggers@...gle.com" <ebiggers@...gle.com>,
	"minwoo.im@...sung.com" <minwoo.im@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC: "opensource.kernel@...o.com" <opensource.kernel@...o.com>,
	"luhongfei@...o.com" <luhongfei@...o.com>, Wenxing Cheng
	<wenxing.cheng@...o.com>
Subject: RE: [PATCH] ufs: core: Add HID support

> +What:		/sys/bus/platform/drivers/ufshcd/*/hid_trigger
Maybe have those entries have their own hid directory?
Which will be created if (!hba->dev_info.hid_sup) ?


Snip

> 9614,6 +9619,8 @@ static int __ufshcd_wl_suspend(struct ufs_hba *hba,
> enum ufs_pm_op pm_op)
>  		req_link_state = UIC_LINK_OFF_STATE;
>  	}
> 
> +	if (hba->dev_info.hid_sup)
> +		cancel_delayed_work_sync(&hba->ufs_hid_enable_work);
Is this mean that you need to re-initiate the hid worker, if not completed, on resume?
Then if you are polling the state from user-space anyway, maybe move the entire logic to user-space?
It will simplify your implementation and maybe you could give-up the worker altogether?

Thanks,
Avri