linux-kernel - Re: [PATCH v7 2/8] dt-bindings: PCI: ti,am65: Extend for use with PVU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174496467399.2597920.14844354232532512833.robh@kernel.org>
Date: Fri, 18 Apr 2025 03:24:34 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: huaqian.li@...mens.com
Cc: nm@...com, baocheng.su@...mens.com, linux-pci@...r.kernel.org, 
 diogo.ivo@...mens.com, krzk+dt@...nel.org, 
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, kw@...ux.com, 
 robin.murphy@....com, jan.kiszka@...mens.com, kristo@...nel.org, 
 s-vadapalli@...com, linux-arm-kernel@...ts.infradead.org, 
 lpieralisi@...nel.org, vigneshr@...com, iommu@...ts.linux.dev, 
 linux-kernel@...r.kernel.org, bhelgaas@...gle.com, helgaas@...nel.org, 
 m.szyprowski@...sung.com, devicetree@...r.kernel.org, conor+dt@...nel.org, 
 ssantosh@...nel.org
Subject: Re: [PATCH v7 2/8] dt-bindings: PCI: ti,am65: Extend for use with
 PVU


On Fri, 18 Apr 2025 15:30:20 +0800, huaqian.li@...mens.com wrote:
> From: Jan Kiszka <jan.kiszka@...mens.com>
> 
> The PVU on the AM65 SoC is capable of restricting DMA from PCIe devices
> to specific regions of host memory. Add the optional property
> "memory-regions" to point to such regions of memory when PVU is used.
> 
> Since the PVU deals with system physical addresses, utilizing the PVU
> with PCIe devices also requires setting up the VMAP registers to map the
> Requester ID of the PCIe device to the CBA Virtual ID, which in turn is
> mapped to the system physical address. Hence, describe the VMAP
> registers which are optional unless the PVU shall be used for PCIe.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Li Hua Qian <huaqian.li@...mens.com>
> ---
>  .../bindings/pci/ti,am65-pci-host.yaml        | 34 +++++++++++++++++--
>  1 file changed, 31 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/ti,am65-pci-host.example.dtb: pcie@...0000 (ti,am654-pcie-rc): 'memory-region' is a required property
	from schema $id: http://devicetree.org/schemas/pci/ti,am65-pci-host.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250418073026.2418728-3-huaqian.li@siemens.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.